Skip to content

PEP 508: Add missing parentheses - #1486

Merged
Rosuav merged 1 commit into
python:masterfrom
y9k8i:pep508-add-missing-parentheses
Jul 1, 2020
Merged

Rosuav merged 1 commit into
python:masterfrom
y9k8i:pep508-add-missing-parentheses

Conversation

@y9k8i

@y9k8i y9k8i commented Jun 30, 2020 •

Copy link
Copy Markdown
Contributor

The definition of python_version was updated in #1123.
However, two closing parentheses are missing:

- ``'.'.join(platform.python_version_tuple()[:2]``

``'.'.join(platform.python_version_tuple()[:2]``, to accommodate potential

Note: It is not necessary to change the line 519 because a closing parenthesis exists.

@Rosuav

Rosuav commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

Seems the code in the original PR was right, the textual examples have the typo. Thanks for catching this.

@Rosuav
Rosuav merged commit f9ba5a9 into python:master Jul 1, 2020
@y9k8i
y9k8i deleted the pep508-add-missing-parentheses branch July 1, 2020 00:59
AA-Turner pushed a commit to AA-Turner/peps that referenced this pull request Aug 15, 2020
mnm678 pushed a commit to mnm678/peps that referenced this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants