Skip to content

Restify PEP 206 - #144

Merged
brettcannon merged 1 commit into
python:masterfrom
Mariatta:restify-pep206
Nov 29, 2016
Merged

brettcannon merged 1 commit into
python:masterfrom
Mariatta:restify-pep206

Conversation

@Mariatta

Copy link
Copy Markdown
Member

Straightforward conversion.
I used my (imperfect) script at https://github.com/Mariatta/restify_me for this.
Feedback are welcome :)

Comment thread pep-0206.txt

The PEP is based on an earlier draft PEP by Moshe Zadka, titled
"2.0 Batteries Included."

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PEP does not have the copyright notice, something that's discussed in #123
Should it be added here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @akuchling (the PEP author) can add one or tell you what it should be? (I presume public domain, like all other PEPs, but it's polite to ask.)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gvanrossum :)
I won't make changes wrt copyright notice without @akuchling 's input.
If anything, perhaps it should go in a separate PR anyway?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, adding a copyright can be a separate PR.

@brettcannon

Copy link
Copy Markdown
Member

So if we skip adding a copyright is this PR ready to be committed?

@Mariatta

Copy link
Copy Markdown
Member Author

I tested it locally, and it renders fine.
So, maybe it's ok to merge? :)

@brettcannon
brettcannon merged commit a6f1efa into python:master Nov 29, 2016
@brettcannon

Copy link
Copy Markdown
Member

Travis is green so that's good enough for me. 😄

@brettcannon

Copy link
Copy Markdown
Member

Thanks, BTW!

@Mariatta
Mariatta deleted the restify-pep206 branch March 2, 2017 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants