Skip to content

PEP 581 Updates - #1114

Merged
Mariatta merged 2 commits into
python:masterfrom
Mariatta:pep-581-updates
Jun 27, 2019
Merged

PEP 581 Updates#1114
Mariatta merged 2 commits into
python:masterfrom
Mariatta:pep-581-updates

Conversation

@Mariatta

@Mariatta Mariatta commented Jun 27, 2019

Copy link
Copy Markdown
Member
  • include recent changes to bpo
  • clarify the downsides of GitHub

@Mariatta
PEP 581 Updates
0764dd9 
- include recent changes to bpo
- clarify the downsides of GitHub
gvanrossum
gvanrossum reviewed Jun 27, 2019
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Two nits.

Comment thread pep-0581.rst Outdated
Comment thread pep-0581.rst Outdated
@Mariatta
minor fixes
7d801db 
"not only"
"was" -> "is"
@gvanrossum

gvanrossum commented Jun 27, 2019

Copy link
Copy Markdown
Member

Thanks, LGTM.

@Mariatta
Mariatta merged commit 5f56c05 into python:master Jun 27, 2019
@Mariatta
Mariatta deleted the pep-581-updates branch June 27, 2019 21:43
@Mariatta

Mariatta commented Jun 27, 2019

Copy link
Copy Markdown
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mariatta @gvanrossum @the-knights-who-say-ni