You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Wrong link to PEPs source file when the file ends in .rst #431
Hi,
The issue is simple: the peps pages (eg pep-0553) include a link to the text source file, hosted on GitHub.
But the link points to non-existing .txt files, as some of them are stored as .rst !
The issue comes from the current template:
changed the title [-]Wrong link to PEPs source .txt file on GitHub : they are .rst ![/-][+]Wrong link to PEPs source .txt file on GitHub : some are .rst ![/+]on Oct 18, 2017
changed the title [-]Wrong link to PEPs source .txt file on GitHub : some are .rst ![/-][+]Wrong link to PEPs source file when the file ends in .rst[/+]on Oct 18, 2017
@Mariatta thanks! That's a fix on the website part, and I would be in favor of accepting it asap (maybe even in a more generic way, cf. my review/comment).
As @brettcannon pointed it out, the important changes to be made are #4, known from a long time.
Thanks @Naereen :)
Issue #4 has been completed, the content of the PEPs have all been converted to restructured text format.
I think the consensus for now is to not rename the files from .txt to .rst since GitHub won't properly display the complete file history after the rename. See the discussion.
Activity
Update pep-html-template
Naereen commentedon Oct 18, 2017
#432 fixes this.
(I don't see a reason this could be a bad idea, please someone review)
Naereen commentedon Oct 18, 2017
OK I just saw that half the PEPs are stored as txt and half are stored in rst...
So my fix is stupid, but something should be fixed.
[-]Wrong link to PEPs source .txt file on GitHub : they are .rst ![/-][+]Wrong link to PEPs source .txt file on GitHub : some are .rst ![/+]brettcannon commentedon Oct 18, 2017
It's a known issue that's waiting for #4 to be completed.
[-]Wrong link to PEPs source .txt file on GitHub : some are .rst ![/-][+]Wrong link to PEPs source file when the file ends in .rst[/+]Naereen commentedon Oct 18, 2017
OK, thanks.
Link to the correct PEP source file.
Mariatta commentedon Nov 15, 2017
This PR should take care of it: python/pythondotorg#1195.
Use single quotes and shorten PEP 12's content.
Naereen commentedon Nov 15, 2017
@Mariatta thanks! That's a fix on the website part, and I would be in favor of accepting it asap (maybe even in a more generic way, cf. my review/comment).
As @brettcannon pointed it out, the important changes to be made are #4, known from a long time.
Mariatta commentedon Nov 15, 2017
Thanks @Naereen :)
Issue #4 has been completed, the content of the PEPs have all been converted to restructured text format.
I think the consensus for now is to not rename the files from
.txtto.rstsince GitHub won't properly display the complete file history after the rename. See the discussion.Link to the correct PEP source file. (GH-1195)
Link to the correct PEP source file. (GH-1195)