Repository navigation
Update workflow in PEP 1 #38
Description
PEP 1 needs to be updated to reflect the new GitHub workflow. For example, the following part is now outdated. They can send a pull request on GitHub:
Updates to existing PEPs also come in to peps@python.org. Many PEP
authors are not Python committers yet, so PEP editors do the commits for them.
Activity
warsaw commentedon Aug 2, 2016
This is done now, right?
berkerpeksag commentedon Aug 2, 2016
No, not really :) We still need to update the part I quoted for example: They can just send a pull request now.
warsaw commentedon Aug 2, 2016
@berkerpeksag Okay! I reopened the issue.
warsaw commentedon Oct 13, 2016
The PEP also says:
Is there any objection to just accepting new draft PEPs as PRs too? We'll leave peps@python.org around for questions, help, and such but I don't see much of a need of it for any workflow. It's barely used now as it is.
Closes #38
gvanrossum commentedon Oct 13, 2016
+1, it's been made obsolete by the tracker and PR workflow. (I'd encourage
questions in the tracker too -- it's working great for mypy.)
On Thu, Oct 13, 2016 at 1:46 PM, Barry Warsaw notifications@github.com
wrote:
--Guido van Rossum (python.org/~guido)
warsaw commentedon Oct 13, 2016
+1. I think we should mostly discourage peps@python.org. We can even assign PEP numbers by PR. We'll leave that address live though just in case someone wants to contact the editors semi-privately. Let me do an update to #116
Rosuav commentedon Oct 13, 2016
Hmm. In principle I'm fine with that, as long as it's practical for everyone. For non-core-devs, the normal thing to do used to be to request a PEP number - is the new workflow going to be that every PEP author starts by picking a number and making sure there's no conflict, or do we modify the PR to pick a number?
warsaw commentedon Oct 13, 2016
I would like to see people use an XXX number and we can either assign them a number via PR or modify the PR to assign a number.
gvanrossum commentedon Oct 13, 2016
(Yeah, the new GitHub feature that lets PR reviewers edit the PR is great
for this!)
Personally I'm totally fine with retiring peps@python.org or letting it
bounce a link to the README in the peps repo -- we can then update the
README with typical workflows. (E.g. to reserve a PEP number file an
issue, otherwise use XXX in the PR and allow the reviewers to edit your
branch.)
On Thu, Oct 13, 2016 at 2:01 PM, Barry Warsaw notifications@github.com
wrote:
--Guido van Rossum (python.org/~guido)
Rosuav commentedon Oct 13, 2016
Yeah. Has anyone used the "project admins may tweak the PR" workflow? I'm thinking something along the lines of:
Rosuav commentedon Oct 13, 2016
And... Guido's post and mine crossed. Sounds like you have something similar in mind.
warsaw commentedon Oct 13, 2016
+1
fix python#36 and python#38