Repository navigation
Don't infinite loop on self deps in --follow-imports=normal - #9302
Merged
Merged
Conversation
There are situations in complex SCCs where the semantic analyzer will infer self dependencies, which will cause an infinite loop in dmypy --follow-imports=normal. It's probably a bug that we do that, and that should be fixed to, but fixing a graph algorithm to not infinite loop on self edges seems like a reasonable thing to do in any case. I don't have a minimized test case yet, and am submitting this without one because it should be harmless and because I want it to get into the release.
Closed
JukkaL
approved these changes
Aug 14, 2020
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
I left suggestion about an alternative way of fixing this, but I'm going to merge this as is since I want this for the release. If you think that the suggestion is good, this can be tweaked in a follow-up PR.
| # Filter anything already seen before. This prevents | ||
| # infinite looping if there are any self edges. (Self | ||
| # edges are maybe a bug, but...) | ||
| sources2 = [source for source in sources2 if source.module not in seen] |
Collaborator
There was a problem hiding this comment.
Would it be better to do this filtering in direct_imports?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are situations in complex SCCs where the semantic analyzer will
infer self dependencies, which will cause an infinite loop in dmypy
--follow-imports=normal.
It's probably a bug that we do that, and that should be fixed too, but
fixing a graph algorithm to not infinite loop on self edges seems like
a reasonable thing to do in any case.
I don't have a minimized test case yet, and am submitting this without
one because it should be harmless and because I want it to get into
the release.