Repository navigation
[very much a wip] pep 612 - #9250
Closed
hauntsaninja wants to merge 19 commits into
Closed
hauntsaninja wants to merge 19 commits into
hauntsaninja wants to merge 19 commits into
Conversation
added 19 commits
August 1, 2020 16:14
This allows checkexpr to recognise the call to typing.ParamSpec as producing a special form
Closed
Collaborator
|
Thanks for working on this! This addresses a common user pain point. I haven't had time to look at this in detail, but here are some general thoughts. The implementation doesn't need to be complete before merging -- maintaining a big PR over time gets tedious. Tests need to pass, of course. One option would be to add a command-line flag for enabling experimental features. Another option would be to document the feature as experimental until it's fully implemented and enable it always (this is what we've done previously). |
JukkaL
pushed a commit
that referenced
this pull request
Sep 8, 2020
Linking #8645 Like #9339, much of this is in #9250. However, this PR is a little less self contained, in that it causes several future TODOs. A lot of the changes here are necessitated by changing the type of CallableType.variables to Sequence[TypeVarLikeDef]. This is nice, because it informs me where I need to make changes in the future / integrates a little bit better with existing type var stuff.
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue for PEP 612: #8645