Repository navigation
semanal: populate module_public even for missing modules - #8661
Merged
Merged
Conversation
Member
|
Could you add a test? The Travis failure doesn't look real (it's the docs build). I hit the "restart job" button but not sure if that will help. |
Collaborator
Author
|
I was a little unsure about where to add a test, since module_public isn't widely used and directly checking symbol tables isn't something current unit tests do. But since the issue was originally filed on stubtest, I figure this is okay. |
Collaborator
Author
|
Gentle bump! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8649