Repository navigation
More improvements to following imports in mypy daemon - #8616
Merged
Merged
Conversation
We need to ensure fine-grained deps are loaded and read the AST for a cached module in case it's missing. Reading the AST may also generate errors, so we must be able to propagate them.
msullivan
approved these changes
Apr 2, 2020
msullivan
left a comment
msullivan
left a comment
Collaborator
There was a problem hiding this comment.
This is great. Thanks for all the work simplifying this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a bunch of changes to following imports:
follow_importsseenandsources_setThis may be easier to review by looking at individual commits.
I think that following imports is ready to be enabled after this has been
merged. We can always revert the change before the next release if we
we encounter major issues.
Major things I know about that still don't work (I'll try to address at least the
first one before the next release):
-mand-pdon't work correctly with dmypy (I think that happens alsoin other modes, but might be worse when following imports)
also in other modes)
not critical?)
have better performance and can be used as fallbacks if this is a problem)
Work towards #5870.
Continues progress made in #8590.