[emmatyping]

It turns out it is relatively simple to do this on Windows 10 without dependencies. Note that we can get color output on Windows 7/8 but not really underlining or other VT100 features. This should be supported on all versions of Windows 10 people are running. I'm not sure Windows 7/8 support is worth it here. Windows 7 is EOL at the end of the year, and Windows 8.1 has only 5% market share.

Fixes #7437

[ilevkivskyi]

Nice, it is great to have good support across all platforms! I just have couple small suggestions.

Have you checked that get_terminal_width() works as expected and there are no problems with the daemon?

[emmatyping]

Here is the daemon in action. I also tested and the terminal width information does indeed work.

(ignore the commands being corrupted, that is just a bug in the console itself)

I've gone ahead and followed your suggestions, hopefully the background I gave is enough (I also added a check for major version). Let me know if you have further feedback/suggestions.

[emmatyping]

Huh, that's concerning. I'm not sure why the daemon timeouts happened. I triggered a new build so hopefully that was a fluke (but I will think about why that could happen).

[ilevkivskyi]

The problem may be because if initialize_unix_colors() exits early the color attributes are not initialized actually, so it will crash right after in __init__(). I think both these methods should return bool, and then the called should set dummy_terminal to the result (and return soon if False).

[ilevkivskyi]

Thanks for updates!

I have couple more comments (feel free to land after you consider them).