Repository navigation
Fix binding of self-types on unions - #7152
Merged
Merged
Conversation
JukkaL
approved these changes
Jul 5, 2019
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
I like how this is a clean fix, and fixes a more general issue than what I reported. Just one comment about tests.
| def same(self: T) -> T: ... | ||
|
|
||
| x: Union[A, C] | ||
| reveal_type(x.same) # N: Revealed type is 'Union[builtins.int, def () -> __main__.C*]' |
Collaborator
There was a problem hiding this comment.
Maybe add a test for class method with a self type?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7149
The fix is quite straightforward, self-types should be bound to each individual component, so I just added only basic tests. Please let me know if you want better test coverage (properties, class-methods) etc.