Repository navigation
New semantic analyzer: fix ambiguity between submodule and local def - #7017
Merged
Merged
Conversation
…nition Now imports are biased to target the submodule of current package target, but elsewhere a local definition with the same name as a submodule takes precedence. Even though this doesn't quite reflect what happens at runtime, this seems to cover the typical use cases well, and the implementation is simple. Fixes #6828.
ilevkivskyi
approved these changes
Jun 18, 2019
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
LGTM! I have a suggestion for removal of some potentially dead code.
| # precedence, but doesn't seem to be important in most use cases. | ||
| node = SymbolTableNode(GDEF, self.modules[possible_module_id]) | ||
| else: | ||
| node = module.names.get(id) |
Member
There was a problem hiding this comment.
Do we still need the special case couple dozen lines below (can't comment there) that checks for submodules added to parent module? (The one that has # Special case: allow replacing submodules with variables.)
It seems to be it should be safe to remove it now.
Collaborator
Author
There was a problem hiding this comment.
I'll look at it later and create a separate PR if it makes sense.
gvanrossum
pushed a commit
that referenced
this pull request
Jun 18, 2019
…nition (#7017) Now imports are biased to target the submodule of current package target, but elsewhere a local definition with the same name as a submodule takes precedence. Even though this doesn't quite reflect what happens at runtime, this seems to cover the typical use cases well, and the implementation is simple. Fixes #6828.
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
…nition (python#7017) Now imports are biased to target the submodule of current package target, but elsewhere a local definition with the same name as a submodule takes precedence. Even though this doesn't quite reflect what happens at runtime, this seems to cover the typical use cases well, and the implementation is simple. Fixes python#6828.
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now imports are biased to target the submodule of current package,
but elsewhere a local definition with the same name as a submodule
takes precedence. Even though this doesn't quite reflect what
happens at runtime, this seems to cover the typical use cases well,
and the implementation is simple.
Fixes #6828.