Repository navigation
All protocols and their explicit subclasses are ABCs - #6042
Merged
Merged
Conversation
JukkaL
approved these changes
Dec 10, 2018
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just one idea about a TODO item.
| defn.info.metaclass_type = defn.info.calculate_metaclass_type() | ||
| if any(info.is_protocol for info in defn.info.mro): | ||
| if (not defn.info.metaclass_type or | ||
| defn.info.metaclass_type.type.fullname() == 'builtins.type'): |
Collaborator
There was a problem hiding this comment.
Maybe add a TODO about checking metaclass conflicts If there is another metaclass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6036