Repository navigation
Avoid type-var collisions in attrs and dataclasses - #5552
Merged
Merged
Conversation
euresti
changed the title
Member
|
I will close and re-open to trigger CI builds (should be fixed now). |
ilevkivskyi
reviewed
Sep 2, 2018
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix!
I have only one comment: typically we add original repros from the issue to the tests (sometimes with few tweaks) to avoid regressions.
Member
|
(Also it looks like you still need to update revealed type in one more test.) |
By convention TypeVars for methods should have negative numbers. Since we're creating these methods we're guaranteed to have -1 free. Fixes python#5542
euresti
force-pushed
the
type_var_issue
branch
from
September 2, 2018 04:20
da8c0e5 to
d20bee8
Compare
Contributor
Author
|
Ok. New test added and tests pass! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was caused because we were using 1 for the ids of the generated types.
Since by convention TypeVars for methods should have negative numbers and we're creating these methods we're guaranteed to have -1 free. So use that instead.
Fixes #5542