Repository navigation
Fix adding a class in a new module and using it - #4761
Merged
Merged
Conversation
We add a field to AnyType indicating---if it was created because of a failed import---what the full name of the imported name is (that is, the name in the importing module).
JukkaL
approved these changes
Mar 20, 2018
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
This seems like a reasonable fix for now. Agreed that generating dependencies from locally imported names would be a better long-term approach. I added one comment about additional test case.
| [out] | ||
| <a[wildcard]> -> m | ||
|
|
||
| [case testMissingModuleClass] |
Collaborator
There was a problem hiding this comment.
Try with an import from a package as well (such as from p.b import A) and using from p import *.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add a field to AnyType indicating---if it was created because of a
failed import---what the full name of the imported name is (that is,
the name in the importing module).
An eventual better solution might be to always generate dependencies to the locally imported name of variables. That would fix #4512 as well.