Repository navigation
Fix recent crashes in forward refs - #4120
Merged
Merged
Conversation
|
I'd appreciate if this could be merged soon so that I can upgrade from 0.521 |
Collaborator
|
Can you fix the merge conflict? |
JukkaL
reviewed
Oct 24, 2017
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fixes! This looks good, but I'll still need to test this with internal Dropbox codebases once the merge conflict has been resolved.
Member
Author
Fixed! |
Member
Author
|
@JukkaL I also now removed some code duplication in code added for |
JukkaL
approved these changes
Oct 25, 2017
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Nice, it's good to have less code duplication!
JukkaL
pushed a commit
that referenced
this pull request
Oct 31, 2017
This adds processing of forward references in two nodes that were previously missing: `OverloadedFuncDef` and `NewTypeExpr.info`. (Note that some tests use `# type: ignore`, the original crash was discovered during serialization with errors ignored.) Fixes #4097.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4097
This adds processing of forward references in two nodes that were previously missing:
OverloadedFuncDefandNewTypeExpr.info.(Note that some tests use
# type: ignore, the original crash was discovered during serialization with errors ignored.)