Skip to content

Python 3.4 support #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 2 commits into from
Jul 19, 2017
Merged

Python 3.4 support #3733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d6f6c5
Update typed_ast and README for Python 3.4 support
emmatyping Jul 18, 2017
e28f12c
update test-requirements.txt for Python3.3/3.4
emmatyping Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ type check them statically. Find bugs in your programs without even
running them!

The type annotation standard has also been backported to earlier
Python 3.x versions. Mypy supports Python 3.3 and later.
Python 3.x versions. Mypy supports Python 3.3 and later.
XML based reports do not work on Python 3.3 and 3.4 on Windows.

For Python 2.7, you can add annotations as comments (this is also
specified in [PEP 484](https://www.python.org/dev/peps/pep-0484/)).
Expand Down Expand Up @@ -156,6 +157,9 @@ In Windows, the script is generally installed in

C:\>\Python34\python \Python34\Scripts\mypy PROGRAM

If you are on Windows using Python 3.3 or 3.4, and would like to use XML reports

@JelleZijlstra JelleZijlstra Jul 19, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this true for all Python versions? On my mac in a venv without lxml I get:

$ mypy --cobertura-xml-report mypy-report mypy/
You must install the lxml package before you can run mypy with `--cobertura-xml-report`.
You can do this with `python3 -m pip install lxml`.

download LXML from [PyPi](https://pypi.python.org/pypi/lxml).

### Working with `virtualenv`

If you are using [`virtualenv`](https://virtualenv.pypa.io/en/stable/),
Expand Down Expand Up @@ -254,9 +258,8 @@ Help wanted
Any help in testing, development, documentation and other tasks is
highly appreciated and useful to the project. There are tasks for
contributors of all experience levels. If you're just getting started,
check out the
[difficulty/easy](https://github.com/python/mypy/labels/difficulty%2Feasy)
label.
ask on the [gitter chat](https://gitter.im/python/typing) for ideas of good
beginner issues.

For more details, see the file [CONTRIBUTING.md](CONTRIBUTING.md).

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def run(self):
data_files=data_files,
classifiers=classifiers,
cmdclass={'build_py': CustomPythonBuild},
install_requires = ['typed-ast >= 1.0.4, < 1.1.0'],
install_requires = ['typed-ast >= 1.1.0, < 1.2.0'],
extras_require = {
':python_version < "3.5"': 'typing >= 3.5.3',
},
Expand Down
2 changes: 1 addition & 1 deletion test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ flake8
flake8-bugbear; python_version >= '3.5'
flake8-pyi; python_version >= '3.6'
lxml; sys_platform != 'win32' or python_version == '3.5' or python_version == '3.6'
typed-ast>=1.0.4,<1.1.0; sys_platform != 'win32' or python_version >= '3.5'
typed-ast>=1.1.0,<1.2.0
pytest>=2.8
pytest-xdist>=1.13
pytest-cov>=2.4.0
Expand Down