Skip to content

Suppress any errors found in a boolean expression after filtering out all possible types. - #3666

Merged
gvanrossum merged 1 commit into
python:masterfrom
rowillia:fix_3643
Jul 12, 2017
Merged

gvanrossum merged 1 commit into
python:masterfrom
rowillia:fix_3643

Conversation

@rowillia

@rowillia rowillia commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

This fixes #3643

@emmatyping

Copy link
Copy Markdown
Member

LGTM (sorry for taking so long to review).

@rowillia

Copy link
Copy Markdown
Contributor Author

Ping @JukkaL ! Mind taking a quick look?

@gvanrossum
gvanrossum merged commit c106579 into python:master Jul 12, 2017
@gvanrossum

Copy link
Copy Markdown
Member

Thanks!

(If you want to do a little cleanup, turning disable/enable-errors into a context manager would perhaps be nice... There are many other things in mypy that would also be better off as context managers.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--strict-optional warns in boolean expression x is not None and x > 10

3 participants