Skip to content

Check for member in type-fallback #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 3 commits into from
Feb 7, 2017
Merged

Check for member in type-fallback #2822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c78c447
check for member in fallback
elazarg Feb 7, 2017
45be745
check for fallback only for type objects
elazarg Feb 7, 2017
4753526
Merge branch 'master' into operator_metaclass
elazarg Feb 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mypy/checkexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2071,6 +2071,8 @@ def has_member(self, typ: Type, member: str) -> bool:
# TODO TupleType => also consider tuple attributes
if isinstance(typ, Instance):
return typ.type.has_readable_member(member)
if isinstance(typ, CallableType) and typ.is_type_obj():
return typ.fallback.type.has_readable_member(member)
elif isinstance(typ, AnyType):
return True
elif isinstance(typ, UnionType):
Expand Down
13 changes: 13 additions & 0 deletions test-data/unit/check-classes.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2831,3 +2831,16 @@ class M(Tuple[int]): pass
class C(metaclass=M): pass # E: Invalid metaclass 'M'

[builtins fixtures/tuple.pyi]

[case testMetaclassOperatorBeforeReversed]
class X:
def __radd__(self, x: int) -> int: ...

class Meta(type):
def __add__(cls, x: X) -> str: ...

class Concrete(metaclass=Meta):
pass

reveal_type(Concrete + X()) # E: Revealed type is 'builtins.str'
Concrete + "hello" # E: Unsupported operand types for + ("Meta" and "str")