Skip to content

Assert that Parameters are not passed to tuples - #20477

Merged
hauntsaninja merged 1 commit into
python:masterfrom
A5rocks:tuple-not-parameters
Dec 30, 2025
Merged

hauntsaninja merged 1 commit into
python:masterfrom
A5rocks:tuple-not-parameters

Conversation

@A5rocks

@A5rocks A5rocks commented Dec 26, 2025

Copy link
Copy Markdown
Collaborator

Fixes #20452. I also noticed TypeVarTuples have the same issue, so I fixed that too.

@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@Vaishnavi-KN16

Copy link
Copy Markdown

Hi @A5rocks,
all checks and mypy_primer are passing now.
Please let me know if you’d like any changes from my side. Thanks!

@A5rocks

A5rocks commented Dec 29, 2025

Copy link
Copy Markdown
Collaborator Author

WDYM your side?

@Vaishnavi-KN16

Vaishnavi-KN16 commented Dec 29, 2025 •

Copy link
Copy Markdown

Sorry @A5rocks I meant if you have any feedback or requested changes for me to address, I am happy to update the PR.

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja
hauntsaninja merged commit 7745c7f into python:master Dec 30, 2025
23 checks passed
@A5rocks
A5rocks deleted the tuple-not-parameters branch December 30, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tuple[Concatenate[int, ...]] should not be accepted

3 participants