Repository navigation
fix: annotated argument's var node type is explicit, not inferred - #17217
Merged
Merged
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: spark (https://github.com/apache/spark)
+ python/pyspark/core/rdd.py:1662: error: Function does not return a value (it only ever returns None) [func-returns-value]
+ python/pyspark/core/rdd.py:1664: error: Unused "type: ignore" comment [unused-ignore]
|
Contributor
Author
|
Primer outputs look OK:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17216
During conversion from a standard library AST to the mypy AST,
Varnodes were being created insideArgumentnodes without acknowledging the presence of a type annotation, leading to theVarnode's type as being always set as inferred:mypy/mypy/nodes.py
Line 988 in fb31409
This causes an error at
mypy/mypyc/irbuild/expression.py
Lines 161 to 164 in fb31409
The fix simply acknowledges any presence of a type annotation, so the type of the relevant
Varnode is no longer considered inferred if an annotation is present.