Repository navigation
Add test documenting #17230 - #17199
Conversation
|
@hauntsaninja would you mind taking a look? |
|
I'm not Shantanu but I don't think we should add a test that's testing incorrect behavior. Maybe make it an xfail test with the desired behavior. |
|
How do I make it xfail? mypy seems to have a bespoke testing framework. |
|
Grep for |
| async def main() -> None: | ||
| match await func1(True): | ||
| case str(a): | ||
| match await func2(True): |
There was a problem hiding this comment.
Does this nesting add anything to the test? Better to keep tests simple unless the additional complexity tests something interesting.
There was a problem hiding this comment.
I was following the lead of the preceding test case. See above ^
|
Done, thanks. |
|
@JelleZijlstra anything further? |
|
Ping. Can we merge this please? |
|
It's on my list of pending reviews, so I will get to it. However, the repeated pings feel very strange to me. Why is it important to you that we merge a change that just adds a failing test? |
|
It's more important that #17230 is acknowledged certainly. Apologies for the nuisance. |
2 participants
Add a test demonstrating #17230.