Skip to content

Fix: Exit if any config error #15880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cibinmathew wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Exit if any config error #15880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9507ae2
Fix: Exit if any config error
cibinmathew Aug 15, 2023
44a8eb0
Review feedbacks
cibinmathew Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions mypy/config_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,9 +471,9 @@ def parse_section(
if report_type in defaults.REPORTER_NAMES:
report_dirs[report_type] = str(section[key])
else:
print(f"{prefix}Unrecognized report type: {key}", file=stderr)
continue
if key.startswith("x_"):
msg = f"{prefix}Unrecognized report type: {key}"
raise argparse.ArgumentTypeError(msg)
elif key.startswith("x_"):
pass # Don't complain about `x_blah` flags
elif key.startswith("no_") and hasattr(template, key[3:]):
options_key = key[3:]
Expand All @@ -490,7 +490,8 @@ def parse_section(
elif key == "strict":
pass # Special handling below
else:
print(f"{prefix}Unrecognized option: {key} = {section[key]}", file=stderr)
msg = f"{prefix}Unrecognized option: {key} = {section[key]}"
raise argparse.ArgumentTypeError(msg)
if invert:
dv = getattr(template, options_key, None)
else:
Expand All @@ -512,14 +513,14 @@ def parse_section(
try:
v = ct(section.get(key))
except argparse.ArgumentTypeError as err:
print(f"{prefix}{key}: {err}", file=stderr)
continue
msg = f"{prefix}{key}: {err}"
raise argparse.ArgumentTypeError(msg) from err
else:
print(f"{prefix}Don't know what type {key} should have", file=stderr)
continue
except ValueError as err:
print(f"{prefix}{key}: {err}", file=stderr)
continue
msg = f"{prefix}{key}: {err}"
raise ValueError(msg) from err
if key == "strict":
if v:
set_strict_flags()
Expand Down
5 changes: 4 additions & 1 deletion mypy/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1248,7 +1248,10 @@ def set_strict_flags() -> None:
setattr(options, dest, value)

# Parse config file first, so command line can override.
parse_config_file(options, set_strict_flags, config_file, stdout, stderr)
try:
parse_config_file(options, set_strict_flags, config_file, stdout, stderr)
except (argparse.ArgumentTypeError, ValueError) as err:
raise SystemExit(str(err)) from err

# Set strict flags before parsing (if strict mode enabled), so other command
# line options can override.
Expand Down