Skip to content

[partially defined] handle unreachable blocks - #14161

Merged
JukkaL merged 5 commits into
python:masterfrom
ilinum:partial/unreachable
Nov 22, 2022
Merged

JukkaL merged 5 commits into
python:masterfrom
ilinum:partial/unreachable

Conversation

@ilinum

@ilinum ilinum commented Nov 21, 2022

Copy link
Copy Markdown
Collaborator

This adds support for unreachable blocks in partially-defined check.

Currently, this only supports blocks that are detected as unreachable during semantic analysis (so mostly stuff like python version, etc.).
This doesn't support more advanced cases (see #13926 for an example what's not covered).

Closes #13929

@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JukkaL JukkaL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JukkaL
JukkaL merged commit 8fb482f into python:master Nov 22, 2022
@ilinum
ilinum deleted the partial/unreachable branch November 22, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support unreachable blocks in partially defined check

2 participants