Repository navigation
Ensure instances of CallableType can always be hashed - #12741
Merged
Merged
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
May 8, 2022
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
Not sure this is the greatest solution either, but it works and fixes the crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trying to hash an instance of
mypy.types.CallableTypewill crash ifself.fallback.typeis aFakeInfo. Apparently this is the case if theCallableTyperepresents a classmethod alternative constructor on aTypedDict. Such alternative-constructor methods aren't currently supported by mypy, but mypy also shouldn't crash if it comes across them.Fixes #5653 (though I'm not 100% sure if this is the best solution).
Test Plan
Test case added to
check-typeddict.test.