Repository navigation
Improve type inference special case that involves union with Any - #10887
Merged
Merged
Conversation
When trying to match `list[T]` and `list[str] | Any`, previously we gave up, because the union items caused conflicting inferred values for `T` (`str` and `Any`). Work around the issue by dropping `Any` constraints if there are multiple sets of contraints, since we prefer more precise types. This fixes false positives resulting from python/typeshed#5557, which changed some return types to contain unions with `Any` items. See mypy primer results in #10881 for a real-world example of this in sphinx.
ilevkivskyi
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to match
list[T]andlist[str] | Any, previously wegave up, because the union items caused conflicting inferred values
for
T(strandAny). Work around the issue by droppingAnyconstraints if there are multiple sets of contraints, since we
prefer more precise types.
This fixes false positives resulting from python/typeshed#5557,
which changed some return types to contain unions with
Anyitems.See mypy primer results in #10881 for a real-world example of this
in sphinx.