Skip to content

refactor: add contextmanager to VariableRenameVisitor - #10685

Merged
JelleZijlstra merged 4 commits into
python:masterfrom
atakiar:renmaing-use-contextmanagers
Jun 21, 2021
Merged

refactor: add contextmanager to VariableRenameVisitor#10685
JelleZijlstra merged 4 commits into
python:masterfrom
atakiar:renmaing-use-contextmanagers

Conversation

@atakiar

@atakiar atakiar commented Jun 21, 2021

Copy link
Copy Markdown
Contributor

Description

As title. Related to Guido’s coding style suggestion in #1184

Test Plan

Existing tests with # flags: --allow-redefinition should pass. No new test cases were added

JelleZijlstra
JelleZijlstra reviewed Jun 21, 2021
View reviewed changes
Comment thread mypy/renaming.py Outdated
JelleZijlstra
JelleZijlstra reviewed Jun 21, 2021
View reviewed changes
Comment thread mypy/renaming.py Outdated
@JelleZijlstra JelleZijlstra mentioned this pull request Jun 21, 2021
Merged
JelleZijlstra
JelleZijlstra reviewed Jun 21, 2021
View reviewed changes
Comment thread mypy/renaming.py Outdated
@JelleZijlstra
JelleZijlstra merged commit 08e6ba8 into python:master Jun 21, 2021
@atakiar
atakiar deleted the renmaing-use-contextmanagers branch June 21, 2021 19:00
@97littleleaf11 97littleleaf11 mentioned this pull request Sep 3, 2021
Merged
JukkaL pushed a commit that referenced this pull request Sep 6, 2021
@97littleleaf11
Use context manager for Scope (#11053)
725a24a 
Related issue: #1184
Follows up to #10569, #10685

This PR:
* Refactors `Scope`
  - Replaces `Scope.enter_file` with `Scope.module_scope`
  - Replaces `Scope.enter_function` with `Scope.function_scope`
  - Splits `Scope.leave()` into corresponding context manager
* Deletes unused files
freundTech added a commit to freundTech/mypy that referenced this pull request Sep 27, 2021
@freundTech
Fixed more failing tests after merge (Caused by python#10685)
a5eb480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atakiar @JelleZijlstra