Repository navigation
Add Apple Silicon support when building wheels - #10145
Merged
Merged
Conversation
Contributor
|
You should be correct, the explicit skip acknowledges the fact you know you can’t test arm64 wheels on Intel. |
JukkaL
approved these changes
Feb 27, 2021
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Great! Let's try this out. If the build works, I'm going to try using the wheel on my Apple Silicon mac.
Contributor
|
I can test too if there's a place to download it from. |
Collaborator
|
The build completed and created a wheel. Here's a direct download link: https://github.com/mypyc/mypy_mypyc-wheels/releases/download/v0.820%2Bdev.5161d93950cdb6daa5a13559b64e9e016ab78183/mypy-0.820+dev.5161d93950cdb6daa5a13559b64e9e016ab78183-cp39-cp39-macosx_11_0_arm64.whl (from here). |
Collaborator
|
A quick benchmark was 4.3x faster when compiled on Apple Silicon. Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
related to #10114
I add a
CIBW_TEST_SKIPin line 53 according to this. Is it necessary? I am not sure whether it would work or not.