Not finding attributes within __init__ modules when nested under a namespace package #5854

Activity

1. gvanrossum commented on Oct 29, 2018

   

   gvanrossum

   on Oct 29, 2018

   Member

   More actions

   What exactly is the form of the relative imports you have, and what exactly is the error?
2. basicdays commented on Oct 29, 2018

   

   basicdays

   on Oct 29, 2018

   Author

   More actions

   Ok, my apologizes, I went through and tested to make sure I can exactly reproduce the error in a simplified environment. I've committed a simple example of code here: https://github.com/basicdays/mypy_test

   To reproduce, I've been running pipenv run mypy namespace_package. The output is as follows:

   namespace_package/package2/__init__.py:1: error: Module 'namespace_package.package1' has no attribute 'add_stuff'
   

   I wanted to narrow down exactly what causes the error. It seems mypy is not picking up any module exports within __init__.py modules that are nested under a namespace package. Whether or not the __init__ modules are using relative imports don't seem to make a difference.

   It also currently seems to work if I reference a re-export from another module that is not the __init__. For example, if I have namespace_package.package1.module_a, and namespace_package.package1.module_b, and I re-export a function from module_a in module_b.

   Just to clarify my first comment on this issue thread, not having namespace_packages = True causes nothing to be found as expected. I was confused earlier since I also had ignore_missing_imports = True, which masked that issue.
3. basicdays

   changed the title [-]Issues with relative imports in namespace packages[/-] [+]Not finding attributes within __init__ modules when nested under a namespace package[/+] on Oct 29, 2018
4. basicdays commented on Oct 29, 2018

   

   basicdays

   on Oct 29, 2018

   Author

   More actions

   Also just to add, if I add a stubbed __init__.py file directly to namespace_package, then everything works as expected.
5. rafales commented on Nov 30, 2018

   

   rafales

   on Nov 30, 2018

   More actions

   I'm running into the same problem, although with a little bit different setup:

   src
   ├── graphql
   │   ├── setup.py
   │   └── nspkg
   │       └── graphql
   │           └── __init__.py
   └── pytools
       ├── setup.py
       └── nspkg
           └── pytools
               ├── __init__.py
               └── pytools_test.py
   

   I have some problems even figuring out how to run mypy in such monorepo setup. I ended up with something that should work:

   MYPYPATH=./src/pytools mypy --namespace-packages src/graphql/nspkg
   

   but I end up with the following error:

   src/graphql/nspkg/graphql/__init__.py:3: error: Module 'nspkg.pytools' has no attribute 'map_list'
   

   mypy 0.641
6. rafales commented on Nov 30, 2018

   

   rafales

   on Nov 30, 2018

   More actions

   @basicdays
   There is a work around: place empty py.typed files inside package1 and package2 but there is a gotcha: make sure that those packages' names do not conflict with anything that is installed globally.

   Then you can run mypy namespace_package/*
7. rafales commented on Dec 4, 2018

   

   rafales

   on Dec 4, 2018

   More actions

   @basicdays I started working on namespace packages support. I'll contribute this to mypy when it's in better shape, but currently it should work for your setup.

   Make sure that your namespace package is in python path and you'll be able to run mypy --namespace-packages some-folder/. Here's repo: https://github.com/rafales/mypy/tree/namespace-packages
8. basicdays commented on Dec 4, 2018

   

   basicdays

   on Dec 4, 2018

   Author

   More actions

   @rafales Awesome! I'll have to try that out and see what happens when I get the opportunity to.
9. bwahlgreen commented on Jun 13, 2019

   

   bwahlgreen

   on Jun 13, 2019

   More actions

   It looks like I'm currently running into this issue. @rafales I already have an empty py.typed inside my sub-package, nested under a namespace-package. Was/is there any resolution to this issue? I'm happy to provide more information regarding my particular setup, if need be.
10. awelzel

    added 2 commits that reference this issue on Jun 30, 2019

    modulefinder: use only candidate path without __init__.py as namespac…

    ...

    4bc2f84

    modulefinder: use only dirs containing no __init__.py as namespace pa…

    ...

    fc31dfe
11. awelzel commented on Jun 30, 2019

    

    awelzel

    on Jun 30, 2019

    Contributor

    More actions

    We're running into the same issue and had a look. It seems like a simple bug in the FindModuleCache class - see #7108 for the fix and number of tests.

    I tried @rafales test at https://github.com/basicdays/mypy_test and it works correctly after the fix.
12. gvanrossum

    closed this as completedin b724ccaon Jul 3, 2019