Repository navigation
Refactor operator method access and protocol checks to use checkmember.py #5136
Description
Currently code that checks access to dunder operator methods duplicates code in checkmember.py. Apart from code duplication, the code for operators is more simplistic and doesn't cover some corner cases. A similar situation is with accessing attributes for protocol checks.
The common pattern in both cases is that we need almost the same logic as in checkmember.py, but with some steps skipped and error reporting suppressed.
Activity
JukkaL commentedon Jun 4, 2018
One concrete difference is that operator methods on type objects (as opposed to instances) have different semantics -- they can't generally be defined as class/static methods (and there's
__class_getitem__in Python 3.7).Michael0x2a commentedon Aug 16, 2018
Just to add some extra details/clues: I tried removing that call in my recent operators refactor, and it ended up breaking the
pythoneval.testMetaclassOpAccessAnytest case to fail -- I added a TODO about this to the relevant section of the code.Clean-up and move operator access to checkmember.py (#19250)