Refresh of partial type produces the wrong type in fine-grained incremental mode #4464

Activity

1. JukkaL

   added

   bugmypy got something wrongmypy got something wrong

   topic-fine-grained-incremental

   on Jan 12, 2018
2. JukkaL commented on Jan 19, 2018

   

   JukkaL

   on Jan 19, 2018

   CollaboratorAuthor

   More actions

   Here is a vague idea about solving this without altering mypy semantics:

   • Introduce the concept of "bound targets". If a set of some targets are bound, each time one of the targets in the set becomes stale, also process all other targets in this set at the same time. This is subtly different from fine-grained dependencies, where the triggered targets are processed in a separate propagation step.
   • During dependency generation, if we notice a partial type that spans two targets, bind the two targets. Thus they will both be processed together. This actually isn't sufficient as a fix but it might help -- it looks like in the original example both targets actually become stale at the same time, but things still go wrong. We'll need to update deferred processing to support partial types, which might be a bit messy.
   • If two targets are bound, they can never become unbound until server restart, for simplicity. Binding targets when not necessary should be harmless, and it should only incur some (very) minor performance overhead.
3. JukkaL

   self-assigned this

   on Feb 5, 2018
4. JukkaL commented on Mar 12, 2018

   

   JukkaL

   on Mar 12, 2018

   CollaboratorAuthor

   More actions

   This works now (annotation is consistently required for x). We removed support for partial types spanning multiple scopes in fine-grained incremental mode a while ago.
5. JukkaL

   closed this as completedon Mar 12, 2018