Skip to content

Replace --disallow-any flags with separate boolean flags. #4089

Closed

Description

@JelleZijlstra

The --disallow-any flags interact in unexpected ways with other flags and they make configuration more complicated. We should replace them with a set of simple boolean flags. See discussion in #4076.

Activity

  1. gvanrossum commented on Oct 13, 2017

    @gvanrossum
    Member

    When we do this, we should get rid of --disallow-any=unannotated completely, since it would just be a synonym for --disallow-untyped-defs.

  2. JelleZijlstra commented on Oct 13, 2017

    @JelleZijlstra
    MemberAuthor

    #4076 already removes unannotated.

  3. gvanrossum commented on Oct 13, 2017

    @gvanrossum
    Member

    Are you sure? It still looks supported. Maybe you forgot to push a commit?

  4. JelleZijlstra commented on Oct 13, 2017

    @JelleZijlstra
    MemberAuthor

    I think you're right. I'll submit another PR with the rest of my changes, probably not now though.

  5. ilinum commented on Oct 15, 2017

    @ilinum
    Collaborator

    I think it's important that the documentation for the new disallow_any flags is grouped so it is easier to find other disallow_any flags if you're looking at one of them.

    @JelleZijlstra I can try to implement this if you want -- it should be pretty straightforward. But if you want to do it -- feel free to.

  6. added a commit that references this issue on Oct 29, 2017
    03bb9a5
  7. added a commit that references this issue on Oct 30, 2017
    bf90e2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions