Signatures of overloaded methods are incompatible with supertypes, even if they really are #3262

Activity

1. sixolet commented on Apr 26, 2017

   

   sixolet

   on Apr 26, 2017 via email

   Collaborator

   More actions

   This looks like me, if somebody else doesn't get it first.

   …

   On Apr 26, 2017, at 9:49 AM, Ryan Gonzalez ***@***.***> wrote: e.g. from typing import overload class A: @overload def f(self, x: str) -> str: ... @overload def f(self, y: int) -> int: ... class B(A): @overload def f(self, x: str) -> str: ... @overload def f(self, y: int) -> int: ... @overload def f(self, z: bytes) -> bytes: ... IMO in this case, it should still be compatible, since B supports A's full API, just with another extra function. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
2. refi64 commented on Apr 26, 2017

   

   refi64

   on Apr 26, 2017

   ContributorAuthor

   More actions

   @sixolet I think you might be around 10 seconds too late... ;)
3. refi64

   added a commit that references this issue on Apr 26, 2017

   Fix python#3262: allow subtypes to define more overloads than their s…

   ...

   This issue will close once commit 129ad44 is merged into the 'master' branch.

   129ad44
4. gvanrossum commented on Apr 26, 2017

   

   gvanrossum

   on Apr 26, 2017

   Member

   More actions

   @sixolet Can you review @kirbyfan64's review?
5. sixolet commented on Apr 26, 2017

   

   sixolet

   on Apr 26, 2017 via email

   Collaborator

   More actions

   Yep, though probably tomorrow.

   …

   On Apr 26, 2017, at 10:27 AM, Guido van Rossum ***@***.***> wrote: @sixolet Can you review @kirbyfan64's review? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
6. refi64

   added 2 commits that reference this issue on Apr 27, 2017

   Fix python#3262: allow subtypes to define more overloads than their s…

   ...

   This issue will close once commit f56f49c is merged into the 'master' branch.

   f56f49c

   Fix python#3262: allow subtypes to define more overloads than their s…

   ...

   This issue will close once commit d1ec354 is merged into the 'master' branch.

   d1ec354
7. gvanrossum commented on May 10, 2017

   

   gvanrossum

   on May 10, 2017

   Member

   More actions

   Did this get fixed or not?
8. sixolet commented on May 10, 2017

   

   sixolet

   on May 10, 2017 via email

   Last edited by gvanrossum

   Collaborator

   More actions

   PR [#3263] still out last I checked.
9. ilevkivskyi

   closed this as completedin #3263on Jan 15, 2018
10. ilevkivskyi

    added a commit that references this issue on Jan 15, 2018

    Allow subtypes to define more overloads than their supertype (#3263)

    ...

    This issue will close once commit d187ab3 is merged into the 'master' branch.

    d187ab3