Skip to content

Inferred Union subtype changed inconistently after a failed operation #3122

Open

Description

@pkch

(Based on #3111)

x: Union[int, str]

if isinstance(x, str):
    reveal_type(x)  # Revealed type is 'builtins.str'
    x = x + 1   # E: Unsupported operand types for + ("str" and "int")
    reveal_type(x)  # Revealed type is 'builtins.int'  - CHANGED

if isinstance(x, int):
    reveal_type(x)  # Revealed type is 'builtins.int'
    x = x + 'a'   # E: Unsupported operand types for + ("str" and "int")
    reveal_type(x)  # Revealed type is 'builtins.int'  - DIDN'T CHANGE

I'm not sure whether CHANGE or NO CHANGE should be correct, but it should be consistent.

Related to this:

x: Union[int, str] = 'a'
x = x + 1 # error
reveal_type(x)  # Revealed type: int

Activity

  1. changed the title [-]Inferred Union subtype changed incorrectly after a failed operation[/-] [+]Inferred Union subtype changed inconistently after a failed operation[/+] on Apr 3, 2017
  2. JukkaL commented on Apr 4, 2017

    @JukkaL
    Collaborator

    This boils down to the inferred types of these expressions:

    reveal_type('' + 1)  # int
    reveal_type(1 + '')  # int
    

    This seems inconsistent.

  3. AlexWaygood commented on Mar 24, 2022

    @AlexWaygood
    Member

    The output on mypy 0.941 is slightly different:

    from typing import Union
    
    x: Union[int, str]
    
    if isinstance(x, str):
        reveal_type(x)  # Revealed type is 'builtins.str'
        x = x + 1   # E: Unsupported operand types for + ("str" and "int")
        reveal_type(x)  # Revealed type is 'Union[builtins.int, builtins.str]'  - CHANGED
    
    if isinstance(x, int):
        reveal_type(x)  # Revealed type is 'builtins.int'
        x = x + 'a'   # E: Unsupported operand types for + ("str" and "int")
        reveal_type(x)  # Revealed type is 'builtins.int'  - DIDN'T CHANGE

    And for Jukka's example:

    reveal_type('' + 1)  # Any
    reveal_type(1 + '')  # int
  4. JelleZijlstra commented on Mar 24, 2022

    @JelleZijlstra
    Member

    Possibly related: int.__radd__ exists in typeshed, but str.__radd__ doesn't. This matches reality:

    >>> str.__radd__
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
    AttributeError: type object 'str' has no attribute '__radd__'. Did you mean: '__add__'?
    >>> int.__radd__
    <slot wrapper '__radd__' of 'int' objects>
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions