Skip to content

TypedDict tests don't typecheck #2755

Closed

Description

@ddfisher

Many of the TypedDict tests in mypy/test/testextensions.py don't actually typecheck, even under 3.6 with the eval'd code placed properly in the codebase. This likely indicates a problem with the tests, as the constructs used are intended to typecheck. This is also the only remaining part of mypy that isn't fully typechecked.

Activity

  1. ddfisher commented on Jan 25, 2017

    @ddfisher
    CollaboratorAuthor

    @ilevkivskyi, would you mind taking a look at this at some point?

  2. ilevkivskyi commented on Jan 25, 2017

    @ilevkivskyi
    Member

    Yes, I will try to fix this.

  3. ilevkivskyi commented on Mar 13, 2017

    @ilevkivskyi
    Member

    This depends on python/typeshed#990 and #2492. After these two will be fixed, this one should be easy.

  4. self-assigned this
    on Mar 31, 2017
  5. removed their assignment
    on Dec 9, 2019
  6. 97littleleaf11 commented on Sep 1, 2021

    @97littleleaf11
    Collaborator

    It seems that we don't have mypy/test/testextensions.py any more. Has this issue been fixed already? @ilevkivskyi

  7. ilevkivskyi commented on Sep 1, 2021

    @ilevkivskyi
    Member

    Yes, I think this is not relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions