Repository navigation
--warn-no-return Warns about functions that have no return statements if used in tandem with --strict-optional #2370
Description
UPDATED - This problem appears to happen when --warn-no-return is used in tandem with --strict-optional
test.py:
class Foo():
def __init__(self) -> None:
self.x = 0
def increment_x(self) -> None:
self.x += 1mypy -s --fast-parser --warn-no-return --strict-optional test.py
test.py: note: In member "__init__" of class "Foo":
test.py:2: note: Missing return statement
test.py: note: In member "increment_x" of class "Foo":
test.py:4: note: Missing return statement
Activity
rwbarton commentedon Oct 28, 2016
This is just a bug caused by the fact that
--strict-optionalchanges the meaning of returningNoneinternally in mypy. It works fine without--strict-optional.[-]--warn-no-return Warns about functions that have no return statements[/-][+]--warn-no-return Warns about functions that have no return statements if used in tandem with --strict-optional[/+]rowillia commentedon Oct 28, 2016
Got it. Thanks @rwbarton for figuring out what I meant even though I forgot to specify what my flags were. Changed the title to reflect the actual problem.
ddfisher commentedon Oct 28, 2016
So really this is just a problematic interaction between --warn-no-return and --strict-optional.