Repository navigation
There are no tests for mypy.plugins.proper_plugin #19890
Description
There don't seem to be any tests for mypy.plugins.proper_plugin, which was manually tested for its addition in #16036.
Since mypy apparently owns this code, we should test it.
I've figured out this works as a unit test except that we can't import mypy.types in a unit test.
[case properPlugin]
# flags: --config=tmp/foo.ini
from mypy.types import Type, CallableType
result: Type | None = None
isinstance(result, CallableType)
[file foo.ini]
\[mypy]
plugins=mypy.plugins.proper_plugin
[builtins fixtures/isinstancelist.pyi]I've recently realized this plugin parents its notes wrong, so I'd like to include a regression test for that, but I am having a hard time figuring out how to trigger it.
Activity
ines-bg commentedon Oct 2, 2025
Hi,
Can I work on this issue?
Thanks!
wyattscarpenter commentedon Oct 2, 2025
@ines-bg Yes. There is no process for delegating issues in mypy; whoever wants to work on one can.
This issue may be somewhat difficult to work on if you're new to mypy. Among other things, you will have to become familiar with mypy's bespoke (but very convenient) testing architecture. However, there is some documentation you can read about this, and after that you can read/skim the code that runs the tests. If you are capable of doing that, then I think your odds are good!
There are some issues on this GitHub explicitly tagged good-first-issue if you want to roll the dice on one of them being easier. Many of those seem to already have open pull requests to them, though. There is also good-second-issue , but that's probably the level of difficulty of this issue, anyway.