You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What's the current status here? Has the release branch been cut already?
If not, I'd suggest to do it after the current typeshed sync #18880. This is the last commit with support for type checking Python 3.8. For the next typeshed sync, we'll need to drop support for --python-version 3.8 completely. Might be great to get one last release out before that.
If not, I'd suggest to do it after the current typeshed sync #18880. This is the last commit with support for type checking Python 3.8. For the next typeshed sync, we'll need to drop support for --python-version 3.8 completely. Might be great to get one last release out before that.
Why not just drop 3.8? It has been EOL for over 6 months now
Why not just drop 3.8? It has been EOL for over 6 months now
We already dropped 3.8. It's just that mypy still supports checking 3.8 code with --python-version 3.8 for now. This will become impossible with the next typeshed update #18930.
I'd be fine with dropping it now as well. The idea just was to do one last release before then. The release branch could have even been cut already. I just don't know.
For NumPy #18997 is a big problem. We won't be able to release numpy/numtype (a rework of numpy's typing stubs with new (backwards-incompatible) features like shape-typing).
The plan is to publish an the initial NumType release in one or two months. So if this isn't fixed in mypy 1.16, our only option would be to drop support for mypy. I really don't want that.
@meshy There was a recent change that likely will make ancestors included in seen modules, so I think your PR can likely be simplified. That said however, realistically I think it likely won't make it into 1.16, but I promise I will get back to it as soon as I am done with other 1.16-related work (I was bothered by this issue myself, so I am interested in it being fixed).
@jorenham I strongly suggest you drop this "or otherwise" attitude. If you think it will persuade someone, then I can tell you it will be the opposite.
Reacted by Charlie Denton, Tuukka Mustonen and Anton Agestam
I strongly suggest you drop this "or otherwise" attitude. If you think it will persuade someone, then I can tell you it will be the opposite.
Oh woops I see how it can be interpreted that way, and I did not mean it as a threat or something. I was just trying to say that I consider it to be very important that we keep on supporting mypy, and that I'm therefore willing to help in any way I can in solving this issue.
Reacted by Joren Hammudoglu, Jelle Zijlstra, Charlie Denton, Matei Dibu, steve-mavens, Marc Mueller, Shantanu, Emma Smith, Michael R. Crusoe, yed and 4 more
Three fixes for regressions in 1.16 (well, technically only the first one is a real regression, other two just happen to occur more often for unrelated reasons):
Regardless of patch release, it could be good to roll pretty quickly into a 1.17. There are already some substantial unreleased changes and people will appreciate speed fix from tyralla's PR as well
Mypy 1.16.1 is out with the safe fixes mentioned above cherry picked (a few of them were already cherry picked to 1.16.0). I'll prepare a short blog post tomorrow.
Reacted by Brian Schubert, Joren Hammudoglu, Grische, Stephen Moore, Emma Smith, Michael R. Crusoe, A5rocks and Redoubts
Activity
hauntsaninja commentedon Mar 7, 2025
Note there's a crash on mypy master we may want to address #18764
Update: fixed by Ivan
ilevkivskyi commentedon Mar 31, 2025
FWIW worth including two low-risk crash fixes in the release:
cdce8p commentedon Apr 4, 2025
What's the current status here? Has the release branch been cut already?
If not, I'd suggest to do it after the current typeshed sync #18880. This is the last commit with support for type checking Python 3.8. For the next typeshed sync, we'll need to drop support for
--python-version 3.8completely. Might be great to get one last release out before that.svalentin commentedon Apr 16, 2025
If possible, we should include #18906 in the new release. It fixes high pri daemon bug
jorenham commentedon Apr 16, 2025
Why not just drop 3.8? It has been EOL for over 6 months now
cdce8p commentedon Apr 16, 2025
We already dropped
3.8. It's just that mypy still supports checking 3.8 code with--python-version 3.8for now. This will become impossible with the next typeshed update #18930.jorenham commentedon Apr 16, 2025
Hmm that's too bad. Because #18930 contains
ctypesimprovements (python/typeshed#13777 and python/typeshed#13760) that matter to numpy.cdce8p commentedon Apr 16, 2025
I'd be fine with dropping it now as well. The idea just was to do one last release before then. The release branch could have even been cut already. I just don't know.
meshy commentedon Apr 28, 2025
Will it be possible to have #15043 in 1.16? If not, can I please ask for some feedback on the issue as to what else is required before it's merged?
jorenham commentedon Apr 29, 2025
For NumPy #18997 is a big problem. We won't be able to release numpy/numtype (a rework of numpy's typing stubs with new (backwards-incompatible) features like shape-typing).
The plan is to publish an the initial NumType release in one or two months. So if this isn't fixed in mypy 1.16, our only option would be to drop support for mypy. I really don't want that.
ilevkivskyi commentedon Apr 29, 2025
@meshy There was a recent change that likely will make ancestors included in seen modules, so I think your PR can likely be simplified. That said however, realistically I think it likely won't make it into 1.16, but I promise I will get back to it as soon as I am done with other 1.16-related work (I was bothered by this issue myself, so I am interested in it being fixed).
@jorenham I strongly suggest you drop this "or otherwise" attitude. If you think it will persuade someone, then I can tell you it will be the opposite.
jorenham commentedon Apr 29, 2025
Oh woops I see how it can be interpreted that way, and I did not mean it as a threat or something. I was just trying to say that I consider it to be very important that we keep on supporting mypy, and that I'm therefore willing to help in any way I can in solving this issue.
jorenham commentedon Apr 29, 2025
I opened #19001 to address #18997. Hopefully we can include it in 1.16.
16 remaining items
JukkaL commentedon May 28, 2025
Prepared a revert of #19139 which we can merge if the regression is tricky or slow to fix:
Type[Guard | Is]#19161JukkaL commentedon May 28, 2025
Status of regressions:
Unless there are concerns or new reported regressions, I think we are on track to finally get the release out tomorrow (Thu).
Add changelog for 1.16 (#19138)
Add changelog for 1.16 (#19138)
JukkaL commentedon May 29, 2025
Mypy 1.16 is out: https://mypy-lang.blogspot.com/2025/05/mypy-116-released.html
jorenham commentedon May 29, 2025
Great! Thanks for your hard work and for keeping us in the loop :)
Dreamsorcerer commentedon May 30, 2025
Seems to be some kind of regression here:
https://github.com/aio-libs/aiohttp/actions/runs/15351081200/job/43199239374?pr=11093
As far as I can see, the type should get inferred automatically as Any:
https://github.com/aio-libs/aiohttp/blob/2a8ff49426929569193cb77c67d6682e8b008bce/aiohttp/tracing.py#L48-L58
https://github.com/python/typeshed/blob/a92ecca05417b45d02d9396e4892ca67e80e2891/stdlib/unittest/mock.pyi#L190
If that's not a known/obvious issue, I'll try and look at it in more depth later and open an issue.
Otherwise, this release has allowed us to remove dozens of type ignore comments across our projects, so has been looking pretty good.
ilevkivskyi commentedon May 30, 2025
@Dreamsorcerer I don't think we have an issue about this, and it doesn't look like something obvious. I think better to open a new issue.
Add changelog for 1.16 (python#19138)
ilevkivskyi commentedon Jun 3, 2025
Three fixes for regressions in 1.16 (well, technically only the first one is a real regression, other two just happen to occur more often for unrelated reasons):
Also a fix a (corner case) crash introduced in 1.16:
hauntsaninja commentedon Jun 3, 2025
Regressions fixed:
Unresolved regressions:
Enums of aNamedTuple#19242JukkaL commentedon Jun 6, 2025
Since there were quite a few regressions, I think it's worth making a point release.
#19118 is quite a big change and I think it can wait until 1.17, even though it fixes regressions.
If nobody else beats me to it, I'll probably make the release early next week.
hauntsaninja commentedon Jun 6, 2025
These seem safe to cherry pick:
Type[Guard | Is]#19161 for [1.16 regression] narrowing on is_dataclass #19139These seem less safe to cherry pick:
unreachable,redundant-expr, andredundant-castswarnings in loops more robustly and efficiently, and avoid multiplerevealed typenotes for the same line. #19118 for [1.16 regression] a cast is both needed and redundant at the same time #19170Regardless of patch release, it could be good to roll pretty quickly into a 1.17. There are already some substantial unreleased changes and people will appreciate speed fix from tyralla's PR as well
JukkaL commentedon Jun 16, 2025
Mypy 1.16.1 is out with the safe fixes mentioned above cherry picked (a few of them were already cherry picked to 1.16.0). I'll prepare a short blog post tomorrow.