stubgen often generates incorrect imports

In examples like the following:

from x import y

Stubgen will often lose the from x, and simply generate an import like:

import y

Can you give a full, self-contained example where this happens?

# stubtest/__init__.py

# stubtest/a.py
from . import interfaces

class X(interfaces.Y):
    pass

# stubtest/interfaces.py
class Y:
    pass

> stubgen stubtest.a

# out/stubtest/a.pyi

# Stubs for stubtest.a (Python 3.5)
#
# NOTE: This dynamically typed stub was automatically generated by stubgen.

import interfaces

class X(interfaces.Y): ...

stubgen doesn't ~~keep track of imports~~ attempt to resolve imports with the ast; it simply adds "import foo"

If you have an idea on how to fix this, please submit a PR -- we'll gladly review it!

Hmm… not sure that the reference above pinged anyone, so bump: #3704

I just checked and I think #3169 solved this

Yes, it looks like this is fixed now.

Navigation Menu

Repository navigation

stubgen often generates incorrect imports #1782

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

stubgen often generates incorrect imports #1782

Description

Activity

JukkaL commented on Jul 1, 2016

Diggsey commented on Jul 1, 2016

shangxiao commented on Jul 10, 2017

gvanrossum commented on Jul 10, 2017

shangxiao commented on Jul 13, 2017

dmoisset commented on Sep 25, 2017

ilevkivskyi commented on Sep 25, 2017

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions