assert_type fails to fail for NoReturn #16319

Activity

1. ghost added

   bugmypy got something wrongmypy got something wrong

   on Oct 23, 2023
2. sobolevn commented on Oct 24, 2023

   

   sobolevn

   on Oct 24, 2023

   Member

   More actions

   This happens because mypy does not execute code for Literal[False] branches in if.

   Check this:

   """All three of these assert_type should fail, but only one does, currently."""
   import typing_extensions as t
   
   def f(x: int | bool):
       if isinstance(x, str):
           reveal_type(x)  # not executed
3. sobolevn commented on Oct 24, 2023

   

   sobolevn

   on Oct 24, 2023

   Member

   More actions

   This does not look like a bug to me.