Skip to content

Mypy 1.6 Release Planning #15919

Closed
Closed

Description

@koogoro

I'm planning to make the 1.6 release by the end of August.

Please post any issues you'd like to see fixed in the release here, or any PRs you'd like to have merged. I'll make the release branch release-1.6.

Activity

  1. added
    metaIssues tracking a broad area of work
    on Aug 21, 2023
  2. self-assigned this
    on Aug 21, 2023
  3. koogoro commented on Aug 22, 2023

    @koogoro
    CollaboratorAuthor

    I've run into a regression: #15932.

  4. tyralla commented on Aug 22, 2023

    @tyralla
    Collaborator

    If this is the right place to bring attention to old, so far undiscussed pull requests: #14440

  5. AlexWaygood commented on Aug 27, 2023

    @AlexWaygood
    Member

    It would be good to get #15960 (or an equivalent fix) in before the release. It fixes some recent stubtest regressions that I introduced.

    (EDIT: Now merged! :)

  6. ilevkivskyi commented on Aug 28, 2023

    @ilevkivskyi
    Member

    @koogoro I have a suggestion on the blog post: Could you please mention there that --new-type-infernece will be on by default in 1.7?

  7. koogoro commented on Aug 29, 2023

    @koogoro
    CollaboratorAuthor

    The branch has been created. The new functionality in the attrs plugin to cover fields might cause some errors to pop up for users of attrs but this isn't really a regression and I don't think the primer noticed anything, so I've marked this as a feature request: #15980.

  8. koogoro commented on Aug 29, 2023

    @koogoro
    CollaboratorAuthor

    @AlexWaygood That commit didn't make it onto the branch, and it also doesn't cherry-pick cleanly. Does that mean that the change that introduced the issue didn't make it onto the branch, or would it be good to include multiple more commits on the release branch?

  9. cdce8p commented on Aug 29, 2023

    @cdce8p
    Collaborator

    @koogoro Thanks for creating the release branch. I noticed that it branched of over a week ago. Was that intentional? It's missing a lot of the recent PRs especially from @ilevkivskyi. If you're not too far along with testing it, might I suggest hard reseting the branch to the current master commit? 010da0b That would also include the stubtest fix @AlexWaygood mentioned.

    https://github.com/python/mypy/commits/master
    https://github.com/python/mypy/commits/release-1.6

  10. koogoro commented on Aug 29, 2023

    @koogoro
    CollaboratorAuthor

    @cdce8p The wheels build failed for the latest commit, so I'll use the one before it, d7b2451. Let me quickly check if there are any large problems before hard resetting it.

  11. AlexWaygood commented on Aug 29, 2023

    @AlexWaygood
    Member

    @AlexWaygood That commit didn't make it onto the branch, and it also doesn't cherry-pick cleanly. Does that mean that the change that introduced the issue didn't make it onto the branch, or would it be good to include multiple more commits on the release branch?

    I was hoping 0b303b5 would make it into the release, and if it does, it's important d7b2451 does also, as it fixes some regressions introduced by 0b303b5. But if neither commit makes it in, that's also okay, it can wait :)

    It would be pretty useful if 48835a3 could be included in the release, though — this one fixes a crash that's blocking some typeshed updates.

  12. koogoro commented on Aug 29, 2023

    @koogoro
    CollaboratorAuthor

    I did find one regression in d7b2451: #15984. This regression's new in between that and the current release point, maybe due to some ParamSpec change between the two?

  13. hauntsaninja commented on Aug 31, 2023

    @hauntsaninja
    Collaborator

    It would be good to cherrypick #16004 (fix for #14740 which was highly requested config option). You may also need #15992 for CI to work

  14. hauntsaninja commented on Sep 1, 2023

    @hauntsaninja
    Collaborator

    We should cherrypick #16013 in case we don't have a release before Python 3.12 is out

  15. koogoro commented on Sep 2, 2023

    @koogoro
    CollaboratorAuthor

    Cherry-picked 0ae0c75 as a fix for #15984 and 379b52f as a fix for #15990. I'll cherry-pick #16004 and #16013 once they've been merged.

  16. 13 remaining items

  17. JukkaL commented on Oct 10, 2023

    @JukkaL
    Collaborator
  18. JukkaL commented on Oct 10, 2023

    @JukkaL
    Collaborator
  19. JukkaL commented on Oct 10, 2023

    @JukkaL
    Collaborator

    I will update the website tomorrow, since it's getting late here.

  20. AlexWaygood commented on Oct 11, 2023

    @AlexWaygood
    Member

    A new crash with mypy 1.6, that I hit when trying to bump typeshed's mypy pin:

  21. intgr commented on Oct 11, 2023

    @intgr
    Contributor

    @ymyzk Can you please add mypy 1.6.0 to mypy-play.net?

  22. ymyzk commented on Oct 11, 2023

    @ymyzk

    @intgr Yes, thanks for the reminder. I added mypy 1.6.0 and updated mypy-play.net ymyzk/mypy-playground#488

  23. ilevkivskyi commented on Oct 12, 2023

    @ilevkivskyi
    Member

    An obvious candidate for 1.6.1 #16251 (fixes two closely related crash regressions).

  24. AlexWaygood commented on Oct 13, 2023

    @AlexWaygood
    Member

    Another new crash in mypy 1.6 (that still reproduces with mypy master and the latest version of the release-1.6 branch):

  25. AlexWaygood commented on Oct 13, 2023

    @AlexWaygood
    Member

    #16258 fixes a regression of sorts, so might be worth including in a patch release? But the regression was a new in mypy 1.5 rather than mypy 1.6.

  26. ilevkivskyi commented on Oct 13, 2023

    @ilevkivskyi
    Member

    Also CP for 1.6.1 #16259

  27. intgr commented on Oct 17, 2023

    @intgr
    Contributor

    FYI mypy website https://mypy-lang.org/ does not display the 1.6 release in "What's new"

  28. hauntsaninja commented on Oct 17, 2023

    @hauntsaninja
    Collaborator

    I cherrypicked these to release-1.6 branch and will cut the release later today:

    6b6504eb8 Fix crash on ParamSpec unification (for real) (#16259)
    eb81e63e9 Fix crash on ParamSpec unification (#16251)
    
  29. hauntsaninja commented on Oct 18, 2023

    @hauntsaninja
    Collaborator

    https://pypi.org/project/mypy/1.6.1/ is now a thing

    I also left some notes at https://github.com/python/mypy/wiki/Release-Process#making-a-patch-release so I don't have to grep through my shell history next time to see if I forgot something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

metaIssues tracking a broad area of work

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions