assert == on two floating numbers? Really? #15221

Activity

1. AlexWaygood

   added

   topic-tests

   topic-mypycmypyc bugsmypyc bugs

   on May 11, 2023
2. mcepl commented on May 12, 2023

   

   mcepl

   on May 12, 2023

   Author

   More actions

   Couldn’t you at least something as silly as:

   ---
    mypyc/test-data/run-math.test |    7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)
   
   Index: mypy-1.3.0/mypyc/test-data/run-math.test
   ===================================================================
   --- mypy-1.3.0.orig/mypyc/test-data/run-math.test
   +++ mypy-1.3.0/mypyc/test-data/run-math.test
   @@ -8,6 +8,8 @@ from testutil import assertRaises, float
    
    pymath: Any = math
    
   +FLOAT_MIN_DIFF = 0.0001
   +
    def validate_one_arg(test: Callable[[float], float], validate: Callable[[float], float]) -> None:
        """Ensure that test and validate behave the same for various float args."""
        for x in float_vals:
   @@ -21,9 +23,10 @@ def validate_one_arg(test: Callable[[flo
                    assert repr(e) == repr(e2), f"actual for {x!r}: {e2!r}, expected: {e!r}"
                    continue
            actual = test(x)
   -        assert repr(actual) == repr(expected), (
   +        assert (abs(actual - expected) / expected) < FLOAT_MIN_DIFF, (
                f"actual for {x!r}: {actual!r}, expected {expected!r}")
    
   +
    def validate_two_arg(test: Callable[[float, float], float],
                         validate: Callable[[float, float], float]) -> None:
        """Ensure that test and validate behave the same for various float args."""
   @@ -43,7 +46,7 @@ def validate_two_arg(test: Callable[[flo
                    actual = test(x, y)
                except Exception as e:
                    assert False, f"no exception expected for {args}, got {e!r}"
   -            assert repr(actual) == repr(expected), (
   +            assert (abs(actual - expected) / expected) < FLOAT_MIN_DIFF, (
                    f"actual for {args}: {actual!r}, expected {expected!r}")
    
    def test_sqrt() -> None:

   👍React with 👍1Reacted by wyattscarpenter
3. bmwiedemann

   added a commit that references this issue on May 14, 2023

   Update mypy to version 1.3.0 / rev 37 via SR 1086859

   ...

   3a42332