Enable PEP 692 Support #14697

Activity

1. hmc-cs-mdrissi

   added

   feature

   on Feb 14, 2023
2. PhilReinhold commented on Mar 21, 2023

   

   PhilReinhold

   on Mar 21, 2023

   More actions

   Is all of 692 supported? According to https://peps.python.org/pep-0646/#unpacking-unbounded-tuple-types I think the following should work

   from typing_extensions import Unpack
   x: tuple[str, Unpack[tuple[int, ...]]]
   x = ("a", 1, 2, 3)

   But I currently get (on mypy 1.1.1 on python 3.10.9)

   mypy test.py --enable-incomplete-feature=Unpack
   test.py:5: error: Incompatible types in assignment (expression has type "Tuple[str, int, int, int]", variable has type "Tuple[str, Unpack[Tuple[int, ...]]]")  [assignment]
   

   👍React with 👍1Reacted by Sohang Chopra
3. erictraut commented on Mar 21, 2023

   

   erictraut

   on Mar 21, 2023

   More actions

   PEP 692 applies only to annotations on **kwargs parameters. PEP 646 covers other uses of Unpack including variadic type variables (TypeVarTuple). As far as I know, mypy's support for PEP 646 is not yet complete. See this tracking issue for details.

   👍React with 👍1Reacted by Alex Waygood
4. Avasam commented on Oct 2, 2023

   

   Avasam

   on Oct 2, 2023

   Last edited by Avasam

   SponsorContributor

   More actions

   I feel like this could remove many stubtest allowlist lines in TypeShed (where kwargs are manually unpacked) when fully supported.

   👍React with 👍1Reacted by Sohang Chopra
5. AlexWaygood commented on Oct 3, 2023

   

   AlexWaygood

   on Oct 3, 2023

   Last edited by AlexWaygood

   Member

   More actions

   I feel like this could remove many stubtest allowlist lines in TypeShed (where kwargs are manually unpacked) when fully supported.

   Ooh, a little off-topic, but I'd be curious if you have any examples @Avasam! Stubtest actually already has some special-case logic to specifically allow kwargs to be manually unpacked in a stub if the runtime just has **kwargs. Most times I've seen this kind of thing being allowlisted in typeshed, it's because contributors forgot to make all the "manually unpacked" parameters keyword-only in the stub (bcd4ff2 should help a bit with the error messages here, hopefully :)
6. Avasam commented on Oct 3, 2023

   

   Avasam

   on Oct 3, 2023

   SponsorContributor

   More actions

   Most times I've seen this kind of thing being allowlisted in typeshed, it's because contributors forgot to make all the "manually unpacked" parameters keyword-only in the stub

   Now that you mention it... I'll double check and come back to you (other here or in typeshed PRs). That might be it.

   ❤️React with ❤️1Reacted by Alex Waygood
7. JukkaL

   closed this as completedin #16354on Oct 30, 2023
8. JukkaL

   added a commit that references this issue on Oct 30, 2023

   Enable Unpack/TypeVarTuple support (#16354)

   ...

   ad0e183