0.990 reports error for function with body that is just ellipsis

mypy 0.990 (python 3.8) reports an error for the following source code

def foo() -> int:
    ...

$ mypy foo.py 
/tmp/foo.py:1: error: Missing return statement  [empty-body]
Found 1 error in 1 file (checked 1 source file)

mypy 0.981 would let the same code pass. Was that an intended change in between, or a regression?

From mypy CLI documentation

By default, mypy will generate errors when a function is missing return statements in some execution paths. The only exceptions are when:

The function has a None or Any return type

The function has an empty body or a body that is just ellipsis (...). Empty functions are often used for abstract methods.

I'd expect Success for the given example, because the 2nd exception ("body that is just ellipsis") applies.

This was an intentional change in 0.990 and the special casing for ... bodies was mostly removed (#13729). The documentation seems to be now out of date.

@ilevkivskyi

cc @ilevkivskyi

Yep, I will update the docs. Now you need --allow-empty-bodies if you want old behavior (or disable empty-body error code in your mypy config)

Thank's for clarifying.

Now you need --allow-empty-bodies if you want old behavior

I'm unsure if I want the old behavior🤔 Actually I was ever in doubt if the way I used such ... stubs was good practice. If you have a minute left, would you consider this pseudo code:

class FooStub:
    # Serves as means to check calls to use_generated_foo() with mypy

    def bar() -> int:
        ...

class GeneratedFoo(RuntimeAttrGen, FooStub):
    # Attributes made available at runtime, according to external spec.
    # I control the spec and therefore know what methods and attributes will be available,    
    # but can't hardcode implementations here.
    pass


def use_generated_foo(x: FooStub)
    x.bar()

Would you recommend another approach for type checking such runtime-determined types? E.g., I'd rather avoid deriving from FooStub in favor of structural subtyping. But then I don't know how to associate GeneratedFoo with attributes and methods as in FooStub.

IIUC the situation, my personal preference would be to replace ... with raise AttributeNotGeneratedError. This way if empty stub is used accidentally, you will know immediately, instead of discovering random None somewhere down the call stack.

To clarify, mypy will also not complain about this.

Update --no-warn-no-return docs for empty body changes (#14065)

Navigation Menu

Repository navigation

0.990 reports error for function with body that is just ellipsis #14048

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

0.990 reports error for function with body that is just ellipsis #14048

Description

Activity

JukkaL commented on Nov 9, 2022

JukkaL commented on Nov 9, 2022

ilevkivskyi commented on Nov 9, 2022

haxtibal commented on Nov 9, 2022

ilevkivskyi commented on Nov 9, 2022

ilevkivskyi commented on Nov 9, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions