stubtest: Abstract properties are not detected

Code:

from abc import abstractmethod

class Some:
    @property
    @abstractmethod
    def x(self) -> int:
         return 1

Stub:

class Some:
    @property
    def x(self) -> int: ...

No errors are shown.
It should raise an error about abstract state mismatch.
Realted python/typeshed#8726

I thought you already fixed this in #13323 (comment)? It just hasn't been released yet?

Sorry, I did not mention: I am using master version (0f17aff06ac1c05c442ba989e23655a2c6adbfbf) of course. We even have a test for it here:

mypy/mypy/test/teststubtest.py

Lines 1391 to 1403 in 0f17aff

    
                   yield Case( 
        
                       stub=""" 
        
                       class AP1: 
        
                           def some(self) -> int: ... 
        
                       """, 
        
                       runtime=""" 
        
                       class AP1: 
        
                           @property 
        
                           @abstractmethod 
        
                           def some(self) -> int: ... 
        
                       """, 
        
                       error="AP1.some", 
        
                   )

But, for some reason the example above is not reported.

Oh, this is why:

             class AP1: 
                 def some(self) -> int: ...

We miss @property decorator there.

Got it.

stubtest: Detect abstract properties mismatches (#13647)

Navigation Menu

Repository navigation

stubtest: Abstract properties are not detected #13646

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	yield Case(
	stub="""
	class AP1:
	def some(self) -> int: ...
	""",
	runtime="""
	class AP1:
	@property
	@abstractmethod
	def some(self) -> int: ...
	""",
	error="AP1.some",
	)

stubtest: Abstract properties are not detected #13646

Description

Activity

AlexWaygood commented on Sep 11, 2022

sobolevn commented on Sep 11, 2022

sobolevn commented on Sep 11, 2022

AlexWaygood commented on Sep 11, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions