Skip to content

Handle interaction of -i and -s #1351

Closed

Description

@gvanrossum

When using --incremental mode (-i) with -s (--silent-imports) the cache should technically be invalidated when a different set of files is passed, since imports that are "silenced" by this flag are stored as objects of type Any in the importing module's namespace.

We need this to work seamlessly, either by emptying the cache whenever the set of files changes, or by recording the silenced dependencies in the cache metadata, or by some other approach.

Activity

  1. added this to the milestone on Apr 8, 2016
  2. ddfisher commented on Apr 8, 2016

    @ddfisher
    Collaborator

    Talked in person. It looks like adding some indication in the cache file or metadata that the file was excluded due to -s could be a fruitful approach. We'd need to check if files have explicit dependencies on their silent imports or not (and add that if they don't).

  3. modified the milestones: , on Apr 11, 2016
  4. self-assigned this
    on Apr 11, 2016
  5. gvanrossum commented on Apr 18, 2016

    @gvanrossum
    MemberAuthor

    Fixed by d84bdea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions