Repository navigation
(🐞) Artificially literal bools not considered when performing reachability checks where branch terminates #12365
Description
There is already some disparity between naturally literal bools(annotated with Literal or narrowed) and artificially literal bools (platform, python-version, always-true, TYPE_CHECKING etc):
# mypy: always-true=foo
from typing import Literal
foo: bool
if not foo:
print(1) # no error ✅
bar: Literal[True]
if not bar:
print(1) # error: Statement is unreachable ✅But this is not currently being applied to this situation:
# mypy: always-true=foo
from typing import Literal
foo: bool
def f1() -> None:
if foo:
return
print(1) # error: Statement is unreachable ❌
bar: Literal[True]
def f2() -> None:
if bar:
return
print(1) # error: Statement is unreachable ✅Key:
✅ = correct behavior
❌ = sussy imposter behavior
Activity
[-](🎁) Consider artificially literal bools when performing reachability checks[/-][+](🐞) Artificially literal bools not consider when performing reachability checks where branch terminates[/+][-](🐞) Artificially literal bools not consider when performing reachability checks where branch terminates[/-][+](🐞) Artificially literal bools not considered when performing reachability checks where branch terminates[/+]KotlinIsland commentedon Mar 17, 2022
@a_maintainer Can you mark this as bug(🐞), I updated the title, but can't change the tags(😥)