Repository navigation

`isinstance(x, CallableType) and x.is_type_object()` is a code smell #12320

Open

Labels

bugrefactoringtopic-developer

opened

While fixing #12319 I noticed that if you grep for is_type_object, there are several instances where only CallableTypes are handled. Presumably, these all do the wrong thing for types with overloaded __new__.

hauntsaninja
added
bugmypy got something wrong
on Mar 9, 2022
JelleZijlstra
added
refactoringChanging mypy's internals
on Mar 19, 2022
AlexWaygood
added
topic-developerIssues relevant to mypy developers
on Mar 24, 2022
hauntsaninja
added a commit that references this issue on Sep 23, 2023
Fix various type object handling
c4dcdaa
hauntsaninja
added a commit that references this issue on Oct 1, 2023
Fix cases of type object handling for overloads (#16168)
3d3e482
hauntsaninja
added 2 commits that reference this issue on Jan 29, 2026
Fix some narrowing related object for types with overloaded __new__
1b58fcd
Fix narrowing related code for types with overloaded __new__ (#20676)
956e3ab

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

bugrefactoringtopic-developer

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests