Skip to content

Incompatible return type for overlapping signatures with regards to __new__ #10313

Closed

Description

@hatal175

Bug Report

I came up with this when trying to fix itertools.combinations in typeshed to be a class instead of function.
It seems like mypy doesn't consider Tuple[T,T] to not overlap with Tuple[T, ...] with regards to return type.

I'm not sure if this is a bug or policy, but I would think that a variable length tuple is basically a union of all set length tuples and therefore should accept this.

To Reproduce

See the following code:
`
from typing import Generic, Literal, Tuple, overload,TypeVar

_T = TypeVar("_T")

class A(Generic[_T]):
@overload
def new(cls, a: Literal[1]) -> A[Tuple[int]]:
...
@overload
def new(cls, a: int) -> A[Tuple[int, ...]]:
...
def new(cls, a: int) -> A[Tuple[int, ...]]:
return super().new(cls)
`
mypy returns the following error:
error: Overloaded function signatures 1 and 2 overlap with incompatible return types

(also some error for the implementation return type, but it's irrelevant).

Your Environment

latest mypy, python 3.8.

Tried also on mypy playground with latest mypy and 3.9.

Activity

  1. changed the title [-]Variable length tuples incompatible with set length tuples with regards to return type[/-] [+]Incompatible return type for overlapping signatures with regards to __new__[/+] on Apr 12, 2021
  2. hatal175 commented on Apr 12, 2021

    @hatal175
    ContributorAuthor

    OK, my bad, I haven't researched this enough.
    The issue here is that A[Tuple[int]] and A[Tuple[int,...]] are not subtypes, which they probably aren't. However, I do want to return a single tuple when a is specifically 1 - see https://github.com/python/typeshed/blob/2ae49e130751b9404e6703abe90fe869d63ef065/stdlib/itertools.pyi#L170

  3. hatal175 commented on Apr 13, 2021

    @hatal175
    ContributorAuthor

    I think I made a mistake here with return types and covariant TypeVars. My mistake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugmypy got something wrong

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions