Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
files()is called without an anchor inside a user-defined function namedwrapper, caller inference skips that function as though it werefunctools.singledispatchinternals. A call from another module consequently searches that other module's resources and can raiseFileNotFoundErroreven though the resource exists beside the actual caller.Restrict the wrapper exclusion to frames belonging to
functools. This preserves the documented caller-module behavior, including when importlib_resources has been compiled without its sources.The four new regression cases exercise disk and ZIP packages with both ordinary and compiled-only importlib_resources. All four fail on the original code and pass with the fix. The existing caller-inference tests continue to pass.
Validation on Windows / Python 3.12.10:
test_files.py: 29 passed.tox -e py312: 302 passed, 1 skipped, 11 failures. The unchanged1d55475checkout reproduces the same 11 failures: 10 existing file-level Ruff checks and the_path.builddoctest requiring Windows symlink privileges. Baseline result: 298 passed, 1 skipped.tox -e docs: Sphinx and SphinxLint pass.AI assistance: implemented and tested using Codex, with independent read-only review using Claude Opus. The related source-free caller-inference fix in #314 remains covered by the existing and new tests.